First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

How does this look like in dark mode? Does the star's inside have the background colour? I think that's how it should look like.

Thank you for PR. For now, the logo in the light mode screen looks good to me.

Can you replace the screenshot for login screen after the change? (The current screenshot there seems a duplication of the already-logged-in screen after the change.)

As for the color setting of the "AnkiWeb" text (image), it may need to be changed so that the color switches to black/white in light/dark mode, like the other characters below the logo.

How does this look like in dark mode? Does the star's inside have the background colour? I think that's how it should look like.

@brishtibheja added the screenshots for dark mode. PTAL.

Could you check on the issue/#ankidroid-design for a consensus on the design, then make any changes once consensus is reached

@david-allison Done. Wrote a message on discord channel and made the suggested changes. PTAL.

Thank you for PR. For now, the logo in the light mode screen looks good to me.

Thanks @snowtimeglass, replaced the screenshot with the correct one and changed the text color for dark mode as well. PTAL.

Thank you for the changes. The "AnkiWeb" text looks good to me.

As for the star, perhaps it might be more desirable for the team to approach the upstream to inquire if they could provide the data of the "genuine" AnkiWeb star logo.

Can we move discussion of the design back to the issue.

In particular: I personally feel the designs in #16300 (comment) are better, and we should define what we want this pull request to do before it's reviewed, otherwise there will be a lot of back & forth here

The two-icons-connection concept is also attractive for me, but its design might need some more adjustment. The thin-gray connecting line in the suggested image still doesn't look good enough to me:

(an example image for alternative)

That said, I'm still not sure whether requesting such change of concept and design would be good in this pull request.

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically